-
Notifications
You must be signed in to change notification settings - Fork 467
feat: add span pointer attributes for websocket context propagation #15153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 238 ± 2 ms. The average import time from base is: 240 ± 2 ms. The import time difference between this PR and base is: -2.0 ± 0.1 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate quinna.halim/websocket-context-propagation (8ce6520) with baseline main (1f1ac6a) 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.106µs (SLO: <10.000µs 📉 -48.9%) vs baseline: 📈 +22.6% Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +5.1% ✅ ospathbasename_noaspectTime: ✅ 1.089µs (SLO: <10.000µs 📉 -89.1%) vs baseline: +1.1% Memory: ✅ 37.159MB (SLO: <39.000MB -4.7%) vs baseline: +4.8% ✅ ospathjoin_aspectTime: ✅ 6.933µs (SLO: <10.000µs 📉 -30.7%) vs baseline: 📈 +13.8% Memory: ✅ 37.179MB (SLO: <39.000MB -4.7%) vs baseline: +4.6% ✅ ospathjoin_noaspectTime: ✅ 2.291µs (SLO: <10.000µs 📉 -77.1%) vs baseline: +0.7% Memory: ✅ 37.159MB (SLO: <39.000MB -4.7%) vs baseline: +4.9% ✅ ospathnormcase_aspectTime: ✅ 3.897µs (SLO: <10.000µs 📉 -61.0%) vs baseline: 📈 +13.6% Memory: ✅ 37.159MB (SLO: <39.000MB -4.7%) vs baseline: +4.6% ✅ ospathnormcase_noaspectTime: ✅ 0.572µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.2% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.7% ✅ ospathsplit_aspectTime: ✅ 4.774µs (SLO: <10.000µs 📉 -52.3%) vs baseline: +1.0% Memory: ✅ 37.139MB (SLO: <39.000MB -4.8%) vs baseline: +4.6% ✅ ospathsplit_noaspectTime: ✅ 1.573µs (SLO: <10.000µs 📉 -84.3%) vs baseline: -0.7% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.8% ✅ ospathsplitdrive_aspectTime: ✅ 3.628µs (SLO: <10.000µs 📉 -63.7%) vs baseline: -0.1% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.8% ✅ ospathsplitdrive_noaspectTime: ✅ 0.696µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -1.8% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +5.2% ✅ ospathsplitext_aspectTime: ✅ 4.458µs (SLO: <10.000µs 📉 -55.4%) vs baseline: -0.3% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.9% ✅ ospathsplitext_noaspectTime: ✅ 1.381µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -0.2% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.9% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.438ms (SLO: <22.300ms -8.4%) vs baseline: -0.3% Memory: ✅ 66.149MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.1% ✅ exception-replay-enabledTime: ✅ 1.341ms (SLO: <1.450ms -7.5%) vs baseline: ~same Memory: ✅ 64.268MB (SLO: <67.000MB -4.1%) vs baseline: +4.9% ✅ iastTime: ✅ 20.454ms (SLO: <22.250ms -8.1%) vs baseline: ~same Memory: ✅ 66.090MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.0% ✅ profilerTime: ✅ 15.660ms (SLO: <16.550ms -5.4%) vs baseline: +0.6% Memory: ✅ 54.042MB (SLO: <54.500MB 🟡 -0.8%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 20.569ms (SLO: <21.750ms -5.4%) vs baseline: ~same Memory: ✅ 66.237MB (SLO: <67.000MB 🟡 -1.1%) vs baseline: +5.2% ✅ span-code-originTime: ✅ 25.414ms (SLO: <28.200ms -9.9%) vs baseline: -0.1% Memory: ✅ 67.200MB (SLO: <69.500MB -3.3%) vs baseline: +4.9% ✅ tracerTime: ✅ 20.521ms (SLO: <21.750ms -5.7%) vs baseline: +0.3% Memory: ✅ 66.103MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.1% ✅ tracer-and-profilerTime: ✅ 22.673ms (SLO: <23.500ms -3.5%) vs baseline: ~same Memory: ✅ 68.076MB (SLO: <68.000MB +0.1%) vs baseline: +5.2% ✅ tracer-dont-create-db-spansTime: ✅ 19.275ms (SLO: <21.500ms 📉 -10.3%) vs baseline: -0.1% Memory: ✅ 66.070MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.0% ✅ tracer-minimalTime: ✅ 16.605ms (SLO: <17.500ms -5.1%) vs baseline: ~same Memory: ✅ 66.169MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.2% ✅ tracer-nativeTime: ✅ 20.433ms (SLO: <21.750ms -6.1%) vs baseline: -0.2% Memory: ✅ 67.967MB (SLO: <72.500MB -6.3%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.432ms (SLO: <19.650ms -6.2%) vs baseline: -0.3% Memory: ✅ 66.089MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.1% ✅ tracer-no-databasesTime: ✅ 18.788ms (SLO: <20.100ms -6.5%) vs baseline: +0.2% Memory: ✅ 66.149MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.2% ✅ tracer-no-middlewareTime: ✅ 20.140ms (SLO: <21.500ms -6.3%) vs baseline: ~same Memory: ✅ 66.118MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.1% ✅ tracer-no-templatesTime: ✅ 20.311ms (SLO: <22.000ms -7.7%) vs baseline: +0.5% Memory: ✅ 66.208MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.1% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.063ms (SLO: <19.850ms -9.0%) vs baseline: ~same Memory: ✅ 66.139MB (SLO: <66.500MB 🟡 -0.5%) vs baseline: +4.7% ✅ errortracking-enabled-userTime: ✅ 18.065ms (SLO: <19.400ms -6.9%) vs baseline: ~same Memory: ✅ 66.139MB (SLO: <66.500MB 🟡 -0.5%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 18.048ms (SLO: <19.450ms -7.2%) vs baseline: -0.4% Memory: ✅ 66.100MB (SLO: <66.500MB 🟡 -0.6%) vs baseline: +5.5% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.082ms (SLO: <2.300ms -9.5%) vs baseline: +0.3% Memory: ✅ 52.435MB (SLO: <53.500MB 🟡 -2.0%) vs baseline: +4.5% ✅ errortracking-enabled-userTime: ✅ 2.076ms (SLO: <2.250ms -7.8%) vs baseline: ~same Memory: ✅ 52.396MB (SLO: <53.500MB -2.1%) vs baseline: +4.4% ✅ tracer-enabledTime: ✅ 2.073ms (SLO: <2.300ms -9.9%) vs baseline: ~same Memory: ✅ 52.435MB (SLO: <53.500MB 🟡 -2.0%) vs baseline: +4.5% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.595ms (SLO: <4.750ms -3.3%) vs baseline: +0.2% Memory: ✅ 62.339MB (SLO: <65.000MB -4.1%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 6.619ms (SLO: <6.750ms 🟡 -1.9%) vs baseline: -0.3% Memory: ✅ 62.354MB (SLO: <65.000MB -4.1%) vs baseline: +4.8% ✅ appsec-telemetryTime: ✅ 4.585ms (SLO: <4.750ms -3.5%) vs baseline: -0.8% Memory: ✅ 62.363MB (SLO: <65.000MB -4.1%) vs baseline: +4.8% ✅ debuggerTime: ✅ 1.857ms (SLO: <2.000ms -7.2%) vs baseline: -0.3% Memory: ✅ 45.138MB (SLO: <47.000MB -4.0%) vs baseline: +4.8% ✅ iast-getTime: ✅ 1.856ms (SLO: <2.000ms -7.2%) vs baseline: ~same Memory: ✅ 42.053MB (SLO: <49.000MB 📉 -14.2%) vs baseline: +4.7% ✅ profilerTime: ✅ 1.913ms (SLO: <2.100ms -8.9%) vs baseline: -0.3% Memory: ✅ 46.578MB (SLO: <47.000MB 🟡 -0.9%) vs baseline: +4.6% ✅ resource-renamingTime: ✅ 3.361ms (SLO: <3.650ms -7.9%) vs baseline: -0.5% Memory: ✅ 52.573MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +4.8% ✅ tracerTime: ✅ 3.357ms (SLO: <3.650ms -8.0%) vs baseline: -0.1% Memory: ✅ 52.589MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.348ms (SLO: <3.650ms -8.3%) vs baseline: +0.1% Memory: ✅ 54.244MB (SLO: <60.000MB -9.6%) vs baseline: +4.5% 🟡 recursivecomputation - 8/8✅ deepTime: ✅ 308.209ms (SLO: <320.950ms -4.0%) vs baseline: ~same Memory: ✅ 32.657MB (SLO: <34.500MB -5.3%) vs baseline: +4.7% ✅ deep-profiledTime: ✅ 327.386ms (SLO: <359.150ms -8.8%) vs baseline: ~same Memory: ✅ 38.803MB (SLO: <39.000MB 🟡 -0.5%) vs baseline: +7.3% ✅ mediumTime: ✅ 7.010ms (SLO: <7.400ms -5.3%) vs baseline: ~same Memory: ✅ 31.850MB (SLO: <34.000MB -6.3%) vs baseline: +4.7% ✅ shallowTime: ✅ 0.942ms (SLO: <1.050ms 📉 -10.3%) vs baseline: +0.3% Memory: ✅ 31.850MB (SLO: <34.000MB -6.3%) vs baseline: +4.6%
|
Description
Add span pointers to connect outgoing and incoming messages over websocket; adding attributes to the span links for websocket context propagation.
From RFC:
Testing
See
test_websocket_context_propagationgenerated snapshot filetest_websocket_context_propagationflame graph:websocket.receiveparent andwebsocket.send/websocket.closeRisks
Additional Notes